You are viewing a single comment's thread from:

RE: [Tutorial]: Ionic App Development: Building the Business app part 6(Adding Live loading Charts)

in #utopian-io6 years ago

Thank you for your contribution. Below is our review:

  • I had used chart.js before, not with ionic. It is a cool library, good choice!
  • I can see your text language has improved drastically, nicely done!
  • For the if and else parts of the code, did you really need to repeat the same code twice? you could have placed the content in a unified function that gets called with some params. Worst case you could have also defined data once and made adjustments to it in the else condition.
  • I do not believe you had described the event loop portion that you mentioned in your tutorial plan.
  • Your code is not committed on github, so referencing this comes of no use at the moment to the readers.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for your review, @mcfarhat!

So far this week you've reviewed 4 contributions. Keep up the good work!