RE: Blinkit standalone v1.3 | Themes, notification sounds and webinterface improvements
Thank you for your contribution, a nice update to a project.
Small doubt, a lot of places I have seen you are using only if and not else if, like https://github.com/techtek/Blinkit/commit/66321b387f469f2b955461ea6d67c502396c79cc#diff-fe6449eb7fceb15a3ece3f5c17f7689eR646, is there a reason behind it, can displaytheme variable get more than one value at a time?
Also for this line, https://github.com/techtek/Blinkit/commit/66321b387f469f2b955461ea6d67c502396c79cc#diff-fe6449eb7fceb15a3ece3f5c17f7689eR1004 you are using the below code three times, can this be added as a function and then called, this way your code will look good.
tone(piezopin, 1300, 600); delay(2000);
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @codingdefined!
So far this week you've reviewed 10 contributions. Keep up the good work!
Thank you for moderating, will look into the suggestions and improve them in the next update.