You are viewing a single comment's thread from:
RE: PHP Command to Check the Syntax of a Chess PGN File
Thank you for your contribution. In your single commit, you have changed 47 files with 40,736 additions and 247 deletions, it's better to divide your work across multiple commits. Also all the generated files, which are not useful for the app can be written in the .gitignore file.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Hi @codingdefined, thanks for the review.
Yep, it is better to divide the work across multiple commits. Let me just note that I am squash merging my new features as it is shown in this example: Feature/pgnsyntax (#3)
Is that okay? :) I'd like to squash merge the branches to keep the history of the project a bit more concise.
On the other hand, here is the reason behind so many additions. I just added a few sample PGN files for testing purposes, and those ones contain thousands of lines -- games-02.pgn is an example having 10004 lines.
Thank you for your review, @codingdefined!
So far this week you've reviewed 11 contributions. Keep up the good work!