RE: [Release] Better Crowdin Darkmode - a necessary addon for translating nightowls.
Thanks for the contribution, @jestemkioskiem! I really wonder what Crowdin were thinking as their dark mode is really unacceptable like you said. This should definitely help a lot of our translators, great work!
Some thoughts about the commits (not sure why you linked the two you did, but I'm reviewing this one) made before submitting this contribution (keep in mind I am not an experienced JavaScript developer so take it with a grain of salt):
- Is there a reason you use
varinstead ofletandconst? You could also a for...of statement statement instead. - Should add a space before opening brackets, e.g.
if()->if (). - Maybe you could just use vanilla JavaScript instead of adding jQuery, or if you really want to use a library/framework you can use something like Vue.js instead? I could be chatting absolute shit, though lol.
I would also recommend installing ESLint, as that will help for linting (like PEP8 / pylint for Python).
Also creating pull requests for a feature is great, especially for us reviewers. It immediately makes it clear which commits are relevant to the contribution, but it's not a must of course.
Looking forward to seeing the GUI and customisation implemented, and seeing this makes me want to create a Chrome extension as well, haha.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Hey! You might not (or you might actually absolutely do so) believe me when I say this, but this is the first thing I ever built in JS. jQuery and Vanilla is all I know, so I use them both to best of my abilities. For now they do more than fine and jQuery came in handy when building the GUI later on, which is now working - although still WIP - and I'll be uploading it soon!
Here's a small sneak peak to get you motivated - it was really fun to build, actually.
I am often guilty of spending 30 minutes making changes without checking if they break anything in-between. I was really surprised that very few updates I made introduced more than a syntax error. I might yet fall in love with this language, I guess.
Back to your feedback though:
No reason other than lack of experience. I already started using
letinstead and will change the old ones as well. Will replace the loop too, thanks!Note taken, thanks!
Your feedback is amazing as always and I'm glad to say that I had coded like 3x as much in the same amount of time last night, so you'll get much more to review.
Thank you for your review, @amosbastian!
So far this week you've reviewed 6 contributions. Keep up the good work!
Thank you for your review, @amosbastian!
So far this week you've reviewed 6 contributions. Keep up the good work!