You are viewing a single comment's thread from:

RE: Implemented Home Screen widget Feature to Travel Mate Android app

in #utopian-io6 years ago

Thanks for the contribution, @hiremani! The widget looks nice and useful for people who use Travel Mate, great work!

I would recommend you lead your comments with space, because otherwise it looks like commented out code (in my opinion). Also, was wondering something about the pull request itself: in the section "Type of change" they ask you to put an X for everything that is valid. You selected all three, but it seems to me like the last two contradict each other, haha:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Looking forward to seeing more of your contributions!


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for the review... Yes i will consider your suggestion in my next contribution, Even i had same confusion in selection so checked all 3.... :)

Thank you for your review, @amosbastian!

So far this week you've reviewed 6 contributions. Keep up the good work!