Pull Request Submitted - Update Vote Slider Threshold to Include Delegated SP

in #steemdev7 years ago

After HF 19, a lot of users have been eagerly awaiting the use of the vote slider. Currently the vote slider appears when users have 1 MV of STEEM POWER (currently about 500 SP).

There is a problem with the vote slider though, in that it is not taking into account delegated SP. This causes a problem for new users who get delegated SP from other users, because even though they have enough SP to use the slider - the system doesn't recognize it. @roadscape opened GitHub Issue 1441 for this about a month ago.

I saw a post from @twinner a few days ago about how he tried to delegate SP to 125 German users so that they could use the slider, but then found out after the fact it didn't work! (post here)

I just submitted a pull request to correct the issue. If the pull request is accepted, it will take into account the delegated SP when determining whether or not to show the slider.

The pull request can be viewed here:
https://github.com/steemit/condenser/pull/1547

The PR is not accepted yet, but I plan to work with Steemit, Inc. to make any edits necessary to get it approved. Hopefully we will see the changes up on the live site soon!


Reminder to vote for witnesses!

The Steem witnesses are the elected leaders of the community that power the blockchain. Everybody should learn about the Steem witnesses and vote on who they think is best. If you don't know much about witnesses or aren't sure who to vote for, you can check out this Witness Voting Guide. If you think @timcliff is doing a great job, please consider voting for him as witness! You can vote for witnesses here: https://steemit.com/~witnesses

Sort:  
You are Doing the Same what a Single User is Supposed to do in Open Source Community. Which makes Such Community Grow Faster, Error free & Reliable Because of the individual involvement. Thanks for your effort to present the issue in front of the community...
Thanks - @cWorldV99

valzav merged commit e1e1f43 into steemit:master a day ago

Great work Tim!! Must feel good when you see your efforts aren't in vain. :)

Yes, indeed. It is fun being on the website and coming across things where I get to think 'I did that' :)

LOL. Just as much fun for me when I see something on the website, and I know who did it too. hehe

lol... came here 4 days late to say the same :P

Good news, I am one of those 125 German delegates. Thanks for the post.

I love your avatar :)

This comment has received a 0.02 % upvote from @booster thanks to: @flauwy.

Well done post You deserve for getting Upvote from me. I appreciate on it and like it so much . Waiting for your latest post. Keep your good work and steeming on. Let's walk to my blog. I have a latest post. Your upvote is high motivation for me. Almost all Steemians do their best on this site. Keep steeming and earning.

This comment has received a 0.05 % upvote from @booster thanks to: @hamzaoui.

i appreciate all the hard work you do on our behalf @timcliff . upvoted and resteemed (i already voted for you as a witness- everybody else should too!)

Oh so I have to thank you for this :).

I currently am lending 650 SP from @minnowbooster and suddenly yesterday I saw the slider when I tried to vote something.

Didn't know this was thanks to you.

I guess I have to thank you for the good job :)

Tim, you're the man, thank you for giving me some info which helped me get back access to my steemit account.

You're welcome! I'm glad you were able to get back in :)

Thanks for info, I heard the vote slider appears around 438 SP from someone but I trust you on the 500 SP sounds about right. Slowly getting to 500 SP in time, thanks for update!

Well the exact amount (currently) is 483.385.

I really need this voting slider soon.

wow, this will be a game changer, thanks @timcliff . Steemit is great because of you @timcliff , also @twinner who delegated some steem power to lots of people including me and your team all working behind the scene for our common success. Bless you all. Danke Schön.