Sort:  
  • Trending
    • [-]
     6 years ago 

    Thank you for your contribution @techcoderx !

    1. It is better to use === instead of == (!== instead of !=)in JS and ==true seems redudant.
    2. Some parts of the JS code end with a semicolon but some do not.
    3. some vars could be replaced by either const or let.
    4. The messages you are alert-ing in the JS code could be extracted in a JSON file so that you can internationalize them later.
    5. Unit Tests missing in the project - you could use mocha/chai or other testing frameworks and set up the CI using travis-ci.com

    Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

    To view those questions and the relevant answers related to your post, click here.

    Need help? Chat with us on Discord.

    [utopian-moderator]

    [-]
     6 years ago 

    Thank you for your review, @justyy! Keep up the good work!

    $0.00
      Reply
      [-]
       6 years ago 

      Right on @justyy thank you for the feedback 💪

      Posted using Partiko iOS

      $0.00
        Reply
        [-]
         6 years ago 

        Additional beneficiary fees of up to 2.5% have been introduced for SteemConnect users

        Does this mean that if I publish a post on busy or ulogs using steemconnect to enter there, I will now be charged 2.5% on my post rewards?

        $0.04
        • Past Payouts $0.04
        • - Author $0.03
        • - Curators $0.01
        2 votes
        Reply
        [-]
         6 years ago 

        I'm not sure if it's implemented or not, but that's what the update post said

        $0.00
          Reply
          [-]
           6 years ago 

          Just another reason to use keychain, right?

          Posted using Partiko iOS

          $0.00
            Reply
            [-]
             6 years ago 

            Didn't know that about SteemConnect
            Thank you for the updates :)

            $0.02
            • Past Payouts $0.02
            • - Author $0.02
            • - Curators $0.01
            3 votes
            Reply
            [-]
             6 years ago 

            Once again great job and thanks for including me on the page!

            [-]
             6 years ago 

            Excellent job! The site looks incredible :D

            [-]
             6 years ago 

            What error do you have exactly with SteemConnect?

            [-]
             6 years ago 

            Some of our users were facing the unknown sc2-sdk-error (but they just disappear after some time)

            $0.00
              Reply
              [-]
               6 years ago 

              There should be an error message, did you reported the issue in our GitHub (https://github.com/steemscript/steemconnect) ?

              $0.00
                Reply
                [-]
                 6 years ago (edited)

                The error message looks exactly like this:

                SDKError: sc2-sdk-error

                Looks like it has already been reported by someone else.

                $0.00
                  Reply
                  [-]
                   6 years ago 

                  Thank you i will have a look about it

                  $0.00
                    Reply
                    [-]
                     6 years ago 

                    Great job buddy I love the updates to the webpage looking more professional with each update!

                    Posted using Partiko iOS

                    [-]
                     6 years ago 

                    Saw the post on smoke but seeing how it is a steem post and comment I thought I would make my way here. But this keychain Is a pretty awesome tool for steem that is for sure.

                    Glad to see you guys are doing awesome work on the onelovedtube project

                    [-]
                     6 years ago 

                    Very good work. Well organized and well thought out posts. Great to have onelove services now using keychain!